Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plugin: AnyVideo Downloader #369

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

z1nc0r3
Copy link
Member

@z1nc0r3 z1nc0r3 commented Jul 30, 2024

Plugin for downloading videos from YouTube, Facebook, Twitter, Instagram, and many other websites.

Copy link
Member

@Garulf Garulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flow Launcher uses Embedded Python 3.11 by default. Your release CI is using Python 3.10.

Please update your GitHub workflow to use this version. If your plugin has any non-native Python code this may cause issues for users.

@z1nc0r3
Copy link
Member Author

z1nc0r3 commented Jul 30, 2024

Done ✅

@z1nc0r3 z1nc0r3 requested a review from Garulf July 30, 2024 09:33
@Garulf
Copy link
Member

Garulf commented Jul 30, 2024

@z1nc0r3 I see the change, however you may want to initiate a release with the updated workflow.

@z1nc0r3
Copy link
Member Author

z1nc0r3 commented Jul 30, 2024

Yeah, already ran a release workflow

@Garulf
Copy link
Member

Garulf commented Jul 30, 2024

Yeah I see that now sorry.

image

Wonder why this timestamp didn't update 🤔

@Garulf
Copy link
Member

Garulf commented Jul 30, 2024

Looks awesome!

@Garulf Garulf enabled auto-merge July 30, 2024 09:45
@z1nc0r3
Copy link
Member Author

z1nc0r3 commented Jul 30, 2024

I think the workflow only updates the asset files if there is already a release for that tag. I can see the zip file time is updated.

@Garulf Garulf merged commit 82a2d66 into Flow-Launcher:plugin_api_v2 Jul 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants