Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Height and Dynamic Icon Size #1768

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Dynamic Height and Dynamic Icon Size #1768

merged 7 commits into from
Jan 11, 2023

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Jan 8, 2023

What's the PR

Test Cases

  • Height can be changed
  • Icon Size can be changed
  • Existing themes design should not be affected.
  • The theme preview of the settings should display normally.
  • The height of the number of items should be reflected appropriately when switching themes with different result heights.

Todo

  • Adding an item to a theme document

@github-actions

This comment has been minimized.

- Fix Preview in setting window
- Add ImageIcon Width property
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@onesounds onesounds added the kind/ui related to UI, icons, themes, etc label Jan 9, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 11, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (26)
ASponsor
BLURBEHIND
clocksb
customisations
gamemode
iconsb
installbtn
LINQ
mainwindow
Makesure
Mvvm
otalcmd
positionreset
progressbar
Ptr
scm
TOTALCMD
TRANSPARENTGRADIENT
Txb
uninstallbtn
updatebtn
viewupdate
WCA
windowsb
wpftk
ZIndex
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the dynamic_height branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3897611605/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@onesounds onesounds merged commit 66a5e1a into dev Jan 11, 2023
@onesounds onesounds deleted the dynamic_height branch January 11, 2023 23:58
@jjw24 jjw24 added the enhancement New feature or request label Jan 22, 2023
@jjw24 jjw24 added this to the 1.12.0 milestone Jan 22, 2023
@jjw24
Copy link
Member

jjw24 commented Jan 24, 2023

@onesounds do we need to update Theme documentation?

@onesounds
Copy link
Contributor

onesounds commented Jan 24, 2023

@onesounds do we need to update Theme documentation?

yeah but not to hurry. I added slimlight theme for this function.(example for dynamic height) comment about it in release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/ui related to UI, icons, themes, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set the height of item in theme?
3 participants