Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim fix for notification platform unavailable error #2047

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Apr 12, 2023

Since we will be moving to a new UI framework in the future, this is an interim fix for notification platform unavailable error caused by ModernWpfUI version bump from #1773.

ModernWpfUI v0.9.5 introduced change around WinRT usage that causes notification platform unavailable error for flow on some machines.

Context:

Tests:
Win 10:

  • Notification shown for plugin data reload
  • Notification shown for plugin already installed
  • Notifications shown for plugin install process
  • Plugin Store plugin install pop up is shown
  • Resizing preview window
  • Increasing/Decreasing width of search window via hotkey
  • Increasing/Decreasing maximum displayed result rows via hotkey
    Win 11:
    Same tests as above

Close #1772

ModernWpfUI v0.9.5 introduced WinRT changes that causes Notification platform unavailable error on some machines
@jjw24 jjw24 added the bug Something isn't working label Apr 12, 2023
@jjw24 jjw24 added this to the 1.15.0 milestone Apr 12, 2023
@jjw24 jjw24 self-assigned this Apr 12, 2023
@jjw24 jjw24 marked this pull request as draft April 12, 2023 11:23
@github-actions

This comment has been minimized.

@taooceros
Copy link
Member

I feel like this error only appears in debug? Further, I feel like the root cause is the assemblyloader, in which I think I have made some weird issue but haven't yet got time to resolve.

Though, this might be a good workaround for now if this is consistently reproduced.

@jjw24
Copy link
Member Author

jjw24 commented Apr 12, 2023

It happens for me only in debug, but from the linked issue it happens to some users, and we have had reports that the plugins not installing or only a zip file is downloaded, which is a high probability from the error.

I will take a look at the assemblyloader.

@jjw24
Copy link
Member Author

jjw24 commented Apr 13, 2023

@taooceros, yep looks like the change made by the assembly loader has caused this issue, see comment #1772 (comment)

@taooceros
Copy link
Member

Yes. I remember it is very tricky to fix anyway. The temporary workaround is good enough.

@jjw24 jjw24 marked this pull request as ready for review April 16, 2023 21:16
@jjw24 jjw24 merged commit 274052e into dev Apr 16, 2023
@jjw24 jjw24 deleted the revert_modernwpfui_version_bump branch April 16, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification platform is unavailable error
2 participants