Update to .Net5 #228

taooceros · 2020-11-30T03:35:53Z

.Net 5 Upgrade.
close #197

Net 5 has added several improvement to System.Text.Json, and serialization with private getter and setter has been added.

JohnTheGr8 · 2020-11-30T16:46:18Z

@taooceros looking good thus far.

Remember to also rename the publish profile: Flow.Launcher/Properties/PublishProfiles/NetCore3.1-SelfContained.pubxml

taooceros · 2020-12-01T02:10:21Z

@taooceros looking good thus far.

Remember to also rename the publish profile: Flow.Launcher/Properties/PublishProfiles/NetCore3.1-SelfContained.pubxml

ok

JohnTheGr8 · 2020-12-02T16:43:48Z

@taooceros you forgot to check in the renamed publish-profile file.

jjw24 · 2020-12-02T19:16:08Z

Plugins/Flow.Launcher.Plugin.WebSearch/Flow.Launcher.Plugin.WebSearch.csproj

-    <Page Include="SettingsControl.xaml">
-      <Generator>MSBuild:Compile</Generator>
-      <SubType>Designer</SubType>
-    </Page>
-    <Page Include="SearchSourceSetting.xaml">
-      <Generator>MSBuild:Compile</Generator>
-      <SubType>Designer</SubType>
-    </Page>


is this removal intended?

Yes, it said duplicate page file, since the default page file has included them.

jjw24 · 2020-12-02T19:16:40Z

Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj

@@ -109,7 +109,6 @@
  </ItemGroup>

  <ItemGroup>
-    <PackageReference Include="Microsoft.Windows.SDK.Contracts" Version="10.0.18362.2005" />


is this removal intended?

Sorry, forget to response. Yes, because .Net 5 change the way of using RT. You can see on the TargetFramework of Program plugin is different from simply net5-windows but adding the version number. That replace the nuget package.

jjw24 · 2020-12-02T19:19:14Z

apologies if you have already done so, can we test to double check external plugins still works fine with this upgrade (i know it's just core to 5, but just to make sure)

taooceros · 2020-12-02T23:29:17Z

apologies if you have already done so, can we test to double check external plugins still works fine with this upgrade (i know it's just core to 5, but just to make sure)

Sure, no need for hurry, just put it here for checking.

taooceros · 2020-12-04T14:46:37Z

@taooceros you forgot to check in the renamed publish-profile file.

Thank you for reminding!

taooceros · 2020-12-05T04:47:44Z

Updating to .Net 5 and using WinRT seems cause the new PackageManager() in UWP.cs doesn't work. dotnet/runtime#45632
Not sure why that throw.

jjw24 · 2021-02-11T02:48:51Z

is this still draft or ready for review

taooceros · 2021-02-12T04:53:17Z

This should be ready now

jjw24 · 2021-02-12T07:13:45Z

Could you please list all the tests that have been done so we can cover all basis

taooceros · 2021-02-12T08:32:08Z

Could you please list all the tests that have been done so we can cover all basis

Will do that after I have my computer. 😉

taooceros · 2021-02-12T13:44:59Z

Test Checked:

All internal plugins work as intended.
- Bug for new PackageManager() hasn't been fixed, but it only happens on the first time, so a try catch can fix it.
External plugins work as intended, even when their Target Framework is netcoreapp 3.1
Python plugin works as intended.
Have used it for a while and haven't encountered other bugs.

taooceros · 2021-02-13T05:15:31Z

Another things is that .Net 5 obsolete BinaryFormatter because of security issue (though I think it will be secure for us). Should we find an alternative for that?

jjw24 · 2021-02-14T04:50:54Z

Another things is that .Net 5 obsolete BinaryFormatter because of security issue (though I think it will be secure for us). Should we find an alternative for that?

Where is it used?

taooceros · 2021-02-14T07:30:42Z

Another things is that .Net 5 obsolete BinaryFormatter because of security issue (though I think it will be secure for us). Should we find an alternative for that?

Where is it used?

Only in a few place about the cache. Win32 and UWP, and image usage storage.

jjw24 · 2021-02-14T10:34:30Z

if we can change it, lets do it. Are there any preferred alternatives?

taooceros · 2021-02-14T10:39:46Z

if we can change it, lets do it. Are there any preferred alternatives?

I am not quite sure. Maybe it is quite possible to simply use JsonStorage, but not sure about whether it will be slower. Another alternative is ProtoBuf-net, and I have taken a try, v2 works fine while v3 doesn't work because of the cyclic reference for UWP.

jjw24 · 2021-02-15T20:49:32Z

Remember to update readme as well

jjw24 · 2021-02-23T10:13:30Z

I think that's for the whole 1.8.0 because of the migration of ISavable.

ok so we need to sort Everything out before 1.8.0 goes out then right?

taooceros · 2021-02-23T10:14:50Z

ok so we need to sort Everything out before 1.8.0 goes out then right?

yes, because Everything plugin use an old Flow.Infracturature, but that hasn't been loaded to Flow because Flow exist a new one. Actually, due to the new plugin api changed, everything plugin maybe able to get rid of it.

taooceros · 2021-02-23T10:16:09Z

Let me take a look on whether the xaml do have loaded by default.

jjw24 · 2021-02-23T10:17:49Z

bookmark plugin got the same issue...

taooceros · 2021-02-23T10:19:47Z

bookmark plugin got the same issue...

Will take a look on both. Maybe resource xaml is not included by default, but page xaml does😅

jjw24 · 2021-02-23T10:28:54Z

I tested adding .Net 5 Flow.Launcher.Plugin dll to WindowWalker plugin project which is .Net Core, getting this error:

taooceros · 2021-02-23T10:30:43Z

I tested adding .Net 5 Flow.Launcher.Plugin dll to WindowWalker plugin project which is .Net Core, getting this error:

Yeah they cannot add it since it is higher version. However, if they keep the current Flow.Launcher.Plugin.dll, they can be loaded successfully by flow.

taooceros · 2021-02-23T10:31:12Z

bookmark plugin got the same issue...

Will take a look on both. Maybe resource xaml is not included by default, but page xaml does😅

I add the Content back, and they work. Thank you for the discovery! Seems that only the Page files are loaded by default.

jjw24 · 2021-02-23T10:32:05Z

if they keep the current Flow.Launcher.Plugin.dll, they can be loaded successfully by flow.

but that will mean these plugins will not get the new updates to Plugin project

taooceros · 2021-02-23T10:32:31Z

if they keep the current Flow.Launcher.Plugin.dll, they can be loaded successfully by flow.

but that will mean these plugins will not get the new updates to Plugin project

If they want to get the updated version, they just need to upgrade to .Net 5. It is really easy to do that within a small project. (simply change the targetframework)

jjw24 · 2021-02-23T10:35:42Z

Plugin project will need to be a major version bump then

taooceros · 2021-02-23T10:36:38Z

Plugin project will need to be a major version bump then

Isn't we bump that from 1.4.0 to 1.5.0? Or you mean to bump it to 2.0.0

jjw24 · 2021-02-23T10:37:11Z

bump to 2.0.0, it's a breaking change for plugins

taooceros · 2021-02-23T10:38:21Z

Would you please do that for me? I am not quite sure how to bump version😂

jjw24 · 2021-02-23T10:43:50Z

Would you please do that for me? I am not quite sure how to bump version😂

yeah no problem, leave it with me. I will do that when we release

jjw24 · 2021-02-23T10:46:46Z

are these formatting differences because you are using VSCode?

taooceros · 2021-02-23T10:47:30Z

are these formatting differences because you are using VSCode?

I think so.

taooceros · 2021-02-23T10:50:51Z

Well my VS will format it like this .....

jjw24 · 2021-02-23T10:51:48Z

maybe when you have time have a look at how we can sync the format. I dont want to end up with too many 'fix format' commits 😛

When I get some time I will see if VSCode is a better tool than Visual Studio and switch if so, because i use it for other programming stuff.

taooceros · 2021-02-23T11:00:36Z

maybe when you have time have a look at how we can sync the format. I dont want to end up with too many 'fix format' commits 😛

Yeah sure🤣🤣

When I get some time I will see if VSCode is a better tool than Visual Studio and switch if so, because i use it for other programming stuff.

I think VSCode is quite great for us to use, even though it will not be able to us to track CPU usage and Memory usage with VSCode.
Omnisharp provides similar programing experience with VS, except that it cannot give intellisence for unusing namespace (so I have to manually using System.Linq before using Select, Where, etc.).
Omnisharp will need similar time to load project as VS. However, it won't block the main thread so that if we only want to edit a few files, it would be really fast for us to do that.
For VS, we have to wait for the long startup time.... Generally I won't let VS open until I use it, so VSCode makes me feel really great when I need to only edit one or two line of code comparing to VS.

jjw24 · 2021-02-23T11:32:38Z

except that it cannot give intellisence for unusing namespace (so I have to manually using System.Linq before using Select, Where, etc.).

No wonder occasionally you leave unused namespaces around 😆

PR LGTM, couple more testing and will merge in with 1.8.0

taooceros marked this pull request as ready for review December 1, 2020 02:39

jjw24 reviewed Dec 2, 2020

View reviewed changes

jjw24 assigned taooceros Dec 2, 2020

jjw24 added the enhancement New feature or request label Dec 2, 2020

change publish profile to Net5 one

12891a1

taooceros added 4 commits February 12, 2021 02:23

Merge remote-tracking branch 'upstream/dev' into DotNet5Upgrade

ae94eb7

Update all profile to dotnet 5

a37f191

address a weird bug

b4bc4f0

change version number for global.json

73aa7a1

Merge remote-tracking branch 'upstream/dev' into DotNet5Upgrade

f6192de

Merge branch 'dev' into DotNet5Upgrade

ab4e3f8

add Content back to csproj so that the xamls will be copied

740b792

fix formatting

6aad061

jjw24 enabled auto-merge February 23, 2021 19:05

add comment

479bd75

jjw24 merged commit 374bb79 into Flow-Launcher:dev Feb 23, 2021

jjw24 approved these changes Feb 23, 2021

View reviewed changes

auto-merge was automatically disabled February 23, 2021 19:39
Pull request was closed

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Feb 23, 2021

jjw24 mentioned this pull request Feb 23, 2021

Release 1.8.0 | Plugin 2.0.0 #363

Merged

Update to .Net5 #228

Update to .Net5 #228

Conversation

taooceros commented Nov 30, 2020 • edited by jjw24 Loading

JohnTheGr8 commented Nov 30, 2020

taooceros commented Dec 1, 2020

JohnTheGr8 commented Dec 2, 2020

jjw24 Dec 2, 2020

Choose a reason for hiding this comment

taooceros Dec 2, 2020

Choose a reason for hiding this comment

jjw24 Dec 2, 2020

Choose a reason for hiding this comment

taooceros Dec 4, 2020

Choose a reason for hiding this comment

jjw24 commented Dec 2, 2020 • edited Loading

taooceros commented Dec 2, 2020

taooceros commented Dec 4, 2020

taooceros commented Dec 5, 2020 • edited Loading

jjw24 commented Feb 11, 2021

taooceros commented Feb 12, 2021

jjw24 commented Feb 12, 2021

taooceros commented Feb 12, 2021

taooceros commented Feb 12, 2021

taooceros commented Feb 13, 2021

jjw24 commented Feb 14, 2021

taooceros commented Feb 14, 2021

jjw24 commented Feb 14, 2021

taooceros commented Feb 14, 2021

jjw24 commented Feb 15, 2021

jjw24 commented Feb 23, 2021 • edited Loading

taooceros commented Feb 23, 2021

taooceros commented Feb 23, 2021

jjw24 commented Feb 23, 2021

taooceros commented Feb 23, 2021

jjw24 commented Feb 23, 2021

taooceros commented Feb 23, 2021

taooceros commented Feb 23, 2021 • edited Loading

jjw24 commented Feb 23, 2021

taooceros commented Feb 23, 2021 • edited Loading

jjw24 commented Feb 23, 2021

taooceros commented Feb 23, 2021

jjw24 commented Feb 23, 2021

taooceros commented Feb 23, 2021

jjw24 commented Feb 23, 2021

jjw24 commented Feb 23, 2021 • edited Loading

taooceros commented Feb 23, 2021 • edited Loading

taooceros commented Feb 23, 2021

jjw24 commented Feb 23, 2021 • edited Loading

taooceros commented Feb 23, 2021 • edited Loading

jjw24 commented Feb 23, 2021

taooceros commented Nov 30, 2020 •

edited by jjw24

Loading

jjw24 commented Dec 2, 2020 •

edited

Loading

taooceros commented Dec 5, 2020 •

edited

Loading

jjw24 commented Feb 23, 2021 •

edited

Loading

taooceros commented Feb 23, 2021 •

edited

Loading

taooceros commented Feb 23, 2021 •

edited

Loading

jjw24 commented Feb 23, 2021 •

edited

Loading

taooceros commented Feb 23, 2021 •

edited

Loading

jjw24 commented Feb 23, 2021 •

edited

Loading

taooceros commented Feb 23, 2021 •

edited

Loading