Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix generating api secrets for Team Broker on deploy #491

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Nov 1, 2024

Description

Move to supported way to add API tokens to broker.

This may break the dedicated instance already deployed, We may have to delete the emqx object before upgrading

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

This may break the dedicated instance already deployed

We may have to delete the emqx object before upgrading
@hardillb hardillb requested a review from ppawlowski November 1, 2024 14:58
@hardillb hardillb changed the title Fix generating api secrets for Team Broker on deploy fix: Fix generating api secrets for Team Broker on deploy Nov 1, 2024
@ppawlowski ppawlowski merged commit 3f99940 into main Nov 7, 2024
6 of 7 checks passed
@ppawlowski ppawlowski deleted the fix-api-secret branch November 7, 2024 10:52
@@ -215,7 +220,8 @@ metadata:
type: Opaque
data:
EMQX_DASHBOARD__DEFAULT_PASSWORD: {{ "topSecret" | b64enc | quote }}
api-keys: {{ "flowfuse:verySecret:administrator" | b64enc | quote }}
api-key-name: {{ "flowfuse" | b64enc | quote }}
apit-key-secret: {{ "verySecret" | b64enc | quote }}
Copy link
Contributor

@flecoufle flecoufle Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardillb probably a small typo ? apit -> api
sorry yes fixed by#496

@ppawlowski
Copy link
Contributor

ppawlowski commented Nov 8, 2024

@flecoufle This typo has been fixed in #496 . The latest chart version (2.18.5) should contain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants