Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow MQTT broker container config #506

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

hardillb
Copy link
Contributor

fixes #502

Description

Allow override on container image (to use local cache)

Related Issue(s)

#502 502

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from ppawlowski November 22, 2024 11:03
@hardillb hardillb self-assigned this Nov 22, 2024
@hardillb hardillb changed the title Allow MQTT broker container config fix: Allow MQTT broker container config Nov 22, 2024
hardillb and others added 2 commits November 22, 2024 12:09
Co-authored-by: PPawlowski <ppawlowski@users.noreply.github.com>
@hardillb hardillb requested a review from ppawlowski November 22, 2024 12:10
@ppawlowski
Copy link
Contributor

The failure in the lint workflow is acceptable due to the known error with the chart linting tool not using the new values file.

@hardillb
Copy link
Contributor Author

Fixes for broker service look good to me.

@ppawlowski ppawlowski merged commit fb2038e into main Nov 22, 2024
5 of 6 checks passed
@ppawlowski ppawlowski deleted the mosquitto-image-config branch November 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding of mosquitto broker container image
2 participants