Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to set empty securityContext for all deployments #534

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

ppawlowski
Copy link
Contributor

Description

This pull requests adjusts the way how securityContext is created in each deployment managed by helm chart.
This change allows to provide no values for each securityContext . Since we provide pre-defined values for each of the deployment, now there will be a posibility to completly remove a securityContenxt values by assigining null value to the forge.podSecurityContext.

Related Issue(s)

#526

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb January 20, 2025 20:32
@hardillb
Copy link
Contributor

Making things easier for OpenShift?

@ppawlowski
Copy link
Contributor Author

Making things easier for OpenShift?

Correct.

Without this change spec.template.spec.securityContext values can be overrided only with custom vlaues. This change will allow to set empty spec.template.spec.securityContext .

@hardillb hardillb merged commit 18ec8fa into main Jan 20, 2025
8 checks passed
@hardillb hardillb deleted the fix-podsecuritycontext branch January 20, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants