Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add facebook icon to footer #1299

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add facebook icon to footer #1299

merged 2 commits into from
Nov 6, 2023

Conversation

Yndira-E
Copy link
Contributor

@Yndira-E Yndira-E commented Nov 6, 2023

Description

Added the facebook link/icon to the footer

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E requested a review from ZJvandeWeg November 6, 2023 14:55
@ZJvandeWeg ZJvandeWeg marked this pull request as ready for review November 6, 2023 14:55
ZJvandeWeg
ZJvandeWeg reviewed Nov 6, 2023
View reviewed changes
src/_includes/components/facebook.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this included?

ZJvandeWeg
ZJvandeWeg approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ZJvandeWeg ZJvandeWeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yndira-FlowForge Please remove the file you staged without a need to, the raw svg. Otherwise this looks fine.

@Yndira-E Yndira-E merged commit ac5debb into main Nov 6, 2023
1 check passed
@Yndira-E Yndira-E deleted the add-fb-icon-to-footer branch November 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZJvandeWeg ZJvandeWeg ZJvandeWeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yndira-E @ZJvandeWeg