Add blueprint library page #1313
Conversation
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 39.6%, saving 354.46 KB.
643 images did not require optimisation. |
|
@MarianRaphael, this is the first iteration for the page. It still needs some work, and the idea is to have it synced with https://github.com/FlowFuse/blueprint-library/tree/main. For now, I've simply copied the files from that repository, but those markdown files don't match the proposed structure in the issue. I've also copied the flow.json files, although I'm not sure if you'll need them. How many blueprints and categories do we expect to have? This will determine the structure of the library. |
Yndira-E
force-pushed
the
1256-flowfuse-blueprint-library-page
branch
from
2d145e0 to
262b174
Compare
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 39.6%, saving 354.46 KB.
645 images did not require optimisation. |
|
BTW add /blueprints/ to the preview URL to view the page. Where should we place it in the menu? |
Yndira-E
force-pushed
the
1256-flowfuse-blueprint-library-page
branch
from
8215419 to
1051ad9
Compare
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 39.6%, saving 354.46 KB.
646 images did not require optimisation. |
@Yndira-FlowForge Can you look at how we copy the docs and achieve this PR like this? That's easier to manage for everyone. |
|
@ZJvandeWeg Done! I've opened a PR in the blueprints repository too. Once merged, it should enable the desired rendering. |
Yndira-E
force-pushed
the
1256-flowfuse-blueprint-library-page
branch
from
33055b7 to
b742b2e
Compare
|
First iteration looks good! I need to improve the Readme representation for the website, but I like the concept and its sync with the blueprint repository. |
Yndira-E
force-pushed
the
1256-flowfuse-blueprint-library-page
branch
from
ca3291f to
d56b5b3
Compare
|
Tests are failing, and I believe it's because the blueprints repository is private. One solution involves creating a personal token (which I already did) and adding it as a secret in the website repository; but I don't have access to its settings. Additionally, if I'm understanding correctly, this would tie my gh user to the blueprints repository access, so that content would only be updated if I open the PR. The other solution, could be this one. I consider this is a better option, because it would update regardless of who opens the PR, but I would need help with it, and I think it has to be an admin who creates/adds the app. What do you think? |
Yndira-E
force-pushed
the
1256-flowfuse-blueprint-library-page
branch
from
70234f6 to
5194a13
Compare
|
It's passing the tests now! 🎊 The first issue with the private repository was resolved by @ppawlowski (thank you!). Another issue was related to the path in the image key in the front matter; now, just the filename is enough, as long as it is in the same folder as the markdown file. Since we don't have many blueprints per category, I removed the filter. We can consider adding it as part of a future iteration when we have more blueprints. |
|
PR looks good. I just have to rework all the blueprint READMEs to have better representation on our website. Additionally, not all blueprints in the repo are yet available in Flowfuse due to UI limitations that we will fix next week. |
|
I'll push the 'not yet available' ones to a different branch and start reworking the three crucial ones, to merge as soon as possible |
# Conflicts: # package-lock.json
Yndira-E
force-pushed
the
1256-flowfuse-blueprint-library-page
branch
from
219a332 to
854553b
Compare
Description
First iteration of the blueprint library page
Related Issue(s)
closes #1256
Checklist