Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for auto snapshot #1671

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #1670

Description

Adds a changelog for Device Auto Snapshots

Related Issue(s)

#1670
FlowFuse/flowfuse#3358

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Steve-Mcl Steve-Mcl linked an issue Feb 15, 2024 that may be closed by this pull request
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 10%, saving 5.34 KB.

Filename Before After Improvement Visual comparison
src/changelog/2024/02/images/Device-auto-snapshot1.png 31.69 KB 28.42 KB -10.3% View diff
src/changelog/2024/02/images/Device-auto-snapshot2.png 21.57 KB 19.50 KB -9.6% View diff

757 images did not require optimisation.

@MarianRaphael
Copy link
Contributor

Waiting for the tests

@Steve-Mcl
Copy link
Contributor Author

Waiting for the tests

and maybe a little longer too (I spotted the word "bases" - not a typo, just a wrong word 🤦 Now corrected to "basis" in db70be4

@Steve-Mcl
Copy link
Contributor Author

Odd error (I never touched anything near that)

Error: bad anchors:
  docs/install/kubernetes#upgrading-to-2.0

Found 0 bad links
Found 1 bad anchors
Error: Process completed with exit code 2.

@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented Feb 15, 2024

Odd error (I never touched anything near that)

Error: bad anchors:
  docs/install/kubernetes#upgrading-to-2.0

Found 0 bad links
Found 1 bad anchors
Error: Process completed with exit code 2.

ok, so PR FF PR #3435 removed a section named #upgrading-to-2.0

You can see that in this commit:
https://github.com/FlowFuse/flowfuse/pull/3435/files#diff-aaf193c879080e62a399fe2f964619eac90a031635e559fda1e238130a774399L212

Unrelated error

@Steve-Mcl
Copy link
Contributor Author

@ppawlowski FlowFuse/flowfuse#3435 removed a section named #upgrading-to-2.0 and is causing an error in the website tests.

I don't know what the doc is supposed to be or if it is even relevant now?

Could you take a look?


@MarianRaphael I propose we proceed with this merge and a separate issue/PR is raised to fix bad links

@MarianRaphael MarianRaphael merged commit e803750 into main Feb 15, 2024
6 checks passed
@MarianRaphael MarianRaphael deleted the 1670-add-change-log-to-website-for-auto-snapshot branch February 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add change log to website for Auto Snapshot
2 participants