Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set spacing method does not use parameter #61

Closed
ngonzalezpazFC opened this issue Dec 11, 2020 · 1 comment
Closed

Set spacing method does not use parameter #61

ngonzalezpazFC opened this issue Dec 11, 2020 · 1 comment
Assignees
@ngonzalezpazFC

Comments

@ngonzalezpazFC
Copy link
Contributor

The method in MenuItem class requires a value parameter of boolean type that is not used.
I think the parameter should be removed.
@ngonzalezpazFC ngonzalezpazFC changed the title Set spacing method does not need parameter Set spacing method does not use parameter Dec 11, 2020
@ngonzalezpazFC ngonzalezpazFC self-assigned this Dec 11, 2020
@javier-godoy
Copy link
Member

You're right, but instead of just removing the parameter, @Deprecate the current method and have it invoke the correct way to set icon spacing, in order to avoid introducing a breaking change in the public API.

ngonzalezpazFC added a commit that referenced this issue Dec 11, 2020
@ngonzalezpazFC
fix: deprecate setIconSpacing method
fc7f792 
setIconSpacing(boolean value) does not use its parameter
Add setIconBlank() method

Close #61
ngonzalezpazFC added a commit that referenced this issue Dec 11, 2020
@ngonzalezpazFC
fix: deprecate setIconSpacing method
f8e1606 
setIconSpacing(boolean value) does not use its parameter.
Add setIconBlank() method.
Update demo.

Close #61
javier-godoy pushed a commit that referenced this issue Dec 11, 2020
@ngonzalezpazFC @javier-godoy
feat: add setIconBlank() method
9ede7ee 
Deprecate setIconSpacing(boolean) method that does not use its parameter.
Update demo.

Close #61
javier-godoy pushed a commit that referenced this issue Dec 11, 2020
@ngonzalezpazFC @javier-godoy
feat: add setIconBlank() method
d71b04e 
Deprecate setIconSpacing(boolean) method that does not use its parameter.
Update demo.

Close #61
javier-godoy pushed a commit that referenced this issue Dec 22, 2020
@ngonzalezpazFC @javier-godoy
feat: add setIconBlank() method
10fb6c3 
Deprecate setIconSpacing(boolean) method that does not use its parameter.
Update demo.

Close #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngonzalezpazFC ngonzalezpazFC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javier-godoy @ngonzalezpazFC