Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issue in Vaadin 20 #66

Closed
javier-godoy opened this issue Mar 9, 2021 · 0 comments
Closed

Compatibility issue in Vaadin 20 #66

javier-godoy opened this issue Mar 9, 2021 · 0 comments
Milestone
4.0.0

Comments

@javier-godoy
Copy link
Member

(Vaadin 20.0.0.alpha3 / AppLayoutAddon 4.0.0-SNAPSHOT) The following error occurs:

Error: TypeScript emitted no output for J:\fc\addons\fc-addons-demos-20\node_modules.pnpm@flowingcode\fc-menuitem@0.9.5\node_modules@flowingcode\fc-menuitem\src\iron-collapse-button.ts. By default, ts-loader will not compile .ts files in node_modules.
You should not need to recompile .ts files there, but if you really want to, use the allowTsInNodeModules option.
See: microsoft/TypeScript#12358
javier-godoy added a commit that referenced this issue Apr 19, 2021
@javier-godoy
fix: import fc-menuitem.js instead of .ts
344b372 
Close #66
mlopezFC pushed a commit that referenced this issue Jul 12, 2021
@javier-godoy @mlopezFC
fix: import fc-menuitem.js instead of .ts
fe8c463 
Close #66
javier-godoy added a commit that referenced this issue Jul 12, 2021
@javier-godoy
fix: import fc-menuitem.js instead of .ts
73896da 
Close #66
@javier-godoy javier-godoy added this to the 4.0.0 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@javier-godoy