Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct implementation of setCaption #91

Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix: correct implementation of setCaption #91

merged 1 commit into from
Jan 3, 2022

Conversation

javier-godoy
Copy link
Member

Close #90

mlopezFC
mlopezFC approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlopezFC mlopezFC merged commit 8fa7103 into master Jan 3, 2022
@mlopezFC mlopezFC deleted the fix/90 branch January 3, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlopezFC mlopezFC mlopezFC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setCaption no longer sets the caption
2 participants
@javier-godoy @mlopezFC