Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use setProperty instead of setAttribute #39

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix: use setProperty instead of setAttribute #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b13868
style: apply code formatter
javier-godoy Mar 8, 2024
3acace7
fix: use setProperty instead of setAttribute
javier-godoy Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions src/main/java/com/flowingcode/vaadin/addons/carousel/Carousel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,33 +43,33 @@
@JsModule("@xpertsea/paper-slider/l2t-paper-slider.js")
public class Carousel extends Component implements HasSize {

private static final String HIDE_NAV = "hide-nav";
private static final String DISABLE_SWIPE = "disable-swipe";
private static final String HIDE_NAV = "hideNav";
private static final String DISABLE_SWIPE = "disableSwipe";
private static final String POSITION = "position";
private static final String SLIDE_DURATION = "slide-duration";
private static final String AUTO_PROGRESS = "auto-progress";
private static final String SLIDE_DURATION = "slideDuration";
private static final String AUTO_PROGRESS = "autoProgress";
private static final int DEFAULT_SLIDE_DURATION = 2;

private Slide[] slides;

public Carousel(Slide... paperSlides) {
this.setSlides(paperSlides);
setSlides(paperSlides);
updateSlides(paperSlides);
initProperties();
}

private void updateSlides(Slide... paperSlides) {
for (Slide slide : paperSlides) {
this.getElement().appendChild(slide.getElement());
getElement().appendChild(slide.getElement());
}
}

private void initProperties() {
this.setAutoProgress(false);
this.setSlideDuration(DEFAULT_SLIDE_DURATION);
this.setStartPosition(0);
this.setDisableSwipe(false);
this.setHideNavigation(false);
setAutoProgress(false);
setSlideDuration(DEFAULT_SLIDE_DURATION);
setStartPosition(0);
setDisableSwipe(false);
setHideNavigation(false);
}

// PROPERTIES
Expand All @@ -83,68 +83,68 @@ public void setSlides(Slide[] slides) {
}

public boolean isAutoProgress() {
return this.getElement().getProperty(AUTO_PROGRESS, false);
return getElement().getProperty(AUTO_PROGRESS, false);
}

public void setAutoProgress(boolean autoProgress) {
this.getElement().setAttribute(AUTO_PROGRESS, autoProgress);
getElement().setProperty(AUTO_PROGRESS, autoProgress);
}

public int getSlideDuration() {
return this.getElement().getProperty(SLIDE_DURATION, 0);
return getElement().getProperty(SLIDE_DURATION, 0);
}

public void setSlideDuration(int slideDuration) {
this.getElement().setProperty(SLIDE_DURATION, slideDuration);
getElement().setProperty(SLIDE_DURATION, slideDuration);
}

public int getStartPosition() {
return this.getElement().getProperty(POSITION, 0);
return getElement().getProperty(POSITION, 0);
}

public void setStartPosition(int startPosition) {
this.getElement().setAttribute(POSITION, "" + startPosition);
getElement().setProperty(POSITION, startPosition);
}

public boolean isDisableSwipe() {
return this.getElement().getProperty(DISABLE_SWIPE, false);
return getElement().getProperty(DISABLE_SWIPE, false);
}

public void setDisableSwipe(boolean disableSwipe) {
this.getElement().setAttribute(DISABLE_SWIPE, disableSwipe);
getElement().setProperty(DISABLE_SWIPE, disableSwipe);
}

public boolean isHideNavigation() {
return this.getElement().getProperty(HIDE_NAV, false);
return getElement().getProperty(HIDE_NAV, false);
}

public void setHideNavigation(boolean hideNavigation) {
this.getElement().setAttribute(HIDE_NAV, hideNavigation);
getElement().setProperty(HIDE_NAV, hideNavigation);
}

// FLUENT API
public Carousel withAutoProgress() {
this.setAutoProgress(true);
setAutoProgress(true);
return this;
}

public Carousel withoutSwipe() {
this.setDisableSwipe(true);
setDisableSwipe(true);
return this;
}

public Carousel withoutNavigation() {
this.setHideNavigation(true);
setHideNavigation(true);
return this;
}

public Carousel withSlideDuration(int slideDuration) {
this.setSlideDuration(slideDuration);
setSlideDuration(slideDuration);
return this;
}

public Carousel withStartPosition(int startPosition) {
this.setStartPosition(startPosition);
setStartPosition(startPosition);
return this;
}

Expand All @@ -163,12 +163,12 @@ public String getHeight() {
// METHODS
/** Move to the next slide */
public void moveNext() {
this.getElement().callJsFunction("moveNext");
getElement().callJsFunction("moveNext");
}

/** Move to the previous slide */
public void movePrev() {
this.getElement().callJsFunction("movePrev");
getElement().callJsFunction("movePrev");
}

/**
Expand All @@ -177,7 +177,7 @@ public void movePrev() {
* @param slide
*/
public void movePos(int slide) {
this.getElement().callJsFunction("movePos", "" + slide);
getElement().callJsFunction("movePos", "" + slide);
}

// EVENTS
Expand Down
Loading