You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Font Awesome allows users with a "Pro" subscription to upload custom icons which will include those along with the stock icons. When the icon pack is downloaded, they are included as a style named "custom-icons":
When this custom-icons.svg sprite is placed in the sprites directory as instructed in the README, they are ignored entirely. This can be fixed by adding an entry to mappings at IconsetEnumGenerator:110. I would propose fa-kit as the key, to match the css class used by Font Awesome to target these custom icons. Alternatively, you could use fak, to keep things more in line with the existing keys.
Adding the extra style has one side effect: the Enum name for the Java class is based on the filename of the sprite. However, Java doesn't support hyphens in class names. To allow for easy copy/pasting of these sprites, the code should transform kebab-case into PascalCase automatically when generating the name of the enum.
The text was updated successfully, but these errors were encountered:
jdewaen
pushed a commit
to datadobi/FontAwesomeIronIconset
that referenced
this issue
Oct 13, 2023
Font Awesome allows users with a "Pro" subscription to upload custom icons which will include those along with the stock icons. When the icon pack is downloaded, they are included as a style named "custom-icons":
![image](https://private-user-images.githubusercontent.com/5006742/274899402-118e0a8c-c313-4440-b447-9700b40ceb00.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzNzM5NzMsIm5iZiI6MTcyNDM3MzY3MywicGF0aCI6Ii81MDA2NzQyLzI3NDg5OTQwMi0xMThlMGE4Yy1jMzEzLTQ0NDAtYjQ0Ny05NzAwYjQwY2ViMDAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjNUMDA0MTEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmQwNTk5Mzg1YjYzZTc1NDkyZWU1OTk5NzgwYzYxYjNmZWRhZWVmYzlkNTUzZGZmMmRmYTVkMTMxZjVmMzI5NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Mb-Xt2Rwz6dybGeEnQYk2Kgj7t5j7wEYyZfb5bJvwkU)
When this
custom-icons.svg
sprite is placed in thesprites
directory as instructed in the README, they are ignored entirely. This can be fixed by adding an entry tomappings
atIconsetEnumGenerator:110
. I would proposefa-kit
as the key, to match the css class used by Font Awesome to target these custom icons. Alternatively, you could usefak
, to keep things more in line with the existing keys.Adding the extra style has one side effect: the Enum name for the Java class is based on the filename of the sprite. However, Java doesn't support hyphens in class names. To allow for easy copy/pasting of these sprites, the code should transform kebab-case into PascalCase automatically when generating the name of the enum.
The text was updated successfully, but these errors were encountered: