Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom icons #101

Open
jdewaen opened this issue Oct 13, 2023 · 0 comments · May be fixed by #102
Open

Add support for custom icons #101

jdewaen opened this issue Oct 13, 2023 · 0 comments · May be fixed by #102

Comments

@jdewaen
Copy link
Contributor

jdewaen commented Oct 13, 2023

Font Awesome allows users with a "Pro" subscription to upload custom icons which will include those along with the stock icons. When the icon pack is downloaded, they are included as a style named "custom-icons":
image

When this custom-icons.svg sprite is placed in the sprites directory as instructed in the README, they are ignored entirely. This can be fixed by adding an entry to mappings at IconsetEnumGenerator:110. I would propose fa-kit as the key, to match the css class used by Font Awesome to target these custom icons. Alternatively, you could use fak, to keep things more in line with the existing keys.

Adding the extra style has one side effect: the Enum name for the Java class is based on the filename of the sprite. However, Java doesn't support hyphens in class names. To allow for easy copy/pasting of these sprites, the code should transform kebab-case into PascalCase automatically when generating the name of the enum.

jdewaen pushed a commit to datadobi/FontAwesomeIronIconset that referenced this issue Oct 13, 2023
@paodb paodb added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation Oct 19, 2023
@paodb paodb moved this from Inbox (needs triage) to In Progress in Flowing Code Addons (legacy) Oct 19, 2023
@javier-godoy javier-godoy self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants