-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added MapIdle and BoundChanged Listeners #107
Conversation
I see that commit message is invalid. I've checked the Convention and i think that message is correct. Let me say how can I fix the commit message and I resubmit. Thanks Bruno |
Hi @thiasos , thanks for taking the time for this contribution.
The second commit "feat: add google-map-idle listener" is valid, however the checker would complain because of the other commit. Squashing the commits will be the way to go here. |
Hi @paodb , thanks for you suggestion. I'm using this method in previous version of library (1.8.2) with name "getBound" and works correctly. During merge with master i've noticed of duplicated method and I've renamed it but, my fault, I did'nt exexute test again. I'll follow you suggestion and try to create a new "BoundsChanged" event. Which is project policy in this case? Is better to abort this PullRequest or leave it open and modify once all modification done? Thanks for your time |
7e399b4
to
a27eb61
Compare
I've reviewed the code. Should work correctly now. |
Hello. It's fine if you force-push the PR with the modified code. Regarding our commit practices, we have adopted the principle of "logically atomic commits", i.e. commits that stand by themselves, are big enough to add value to the project, and small enough to read, review and revert. BTW, you can disregard the message stating that "Version 1.9.1-SNAPSHOT cannot contain new features." It's simply a reminder that we should update the version to 1.10.0-SNAPSHOT before merging the new feature. |
@@ -76,6 +77,11 @@ public GoogleMap(String apiKey, String clientId, String language) { | |||
if (!StringUtils.isEmpty(language)) { | |||
this.getElement().setAttribute("language", language); | |||
} | |||
getElement().addEventListener("google-map-ready", event -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this part (lines 80 to 84)? the listeners and the firing of the 'google-map-bounds_changed' should be done in the web-component part of the add-on. I will do that update and once that's ready, we can merge the rest of your changes.
Kudos, SonarCloud Quality Gate passed! |
We just released new version 1.10.0 including these changes. |
added MapIdle Listener and getBound in Synchromized Mode without wait Event from Client