-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method to obtain the map bounds #99
Conversation
setEast(bounds.getNumber("east")); | ||
} | ||
|
||
public double getSouth() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use lombok @Getter
and @Setter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lombok is not being used in the add-on. No need to replace setters/getters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Lombok is not being used in the project, maybe it would be a good idea to remove the dependency. The only problem that I see is that it is a transitive dependency so it might cause issues in projects, so it might be considered a breaking change, so I think that we could implement the removal of the dependency in another PR later.
} | ||
|
||
@Override | ||
public String toString() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotate the class with@ToString(includeFieldNames=true)
instead. See https://projectlombok.org/features/ToString
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lombok is not being used in the add-on.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this change. Regarding the lombok thing, we should create another ticket to discuss what to do.
Close #93