Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to obtain the map bounds #99

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: add method to obtain the map bounds #99

merged 1 commit into from
Aug 31, 2023

Conversation

paodb
Copy link
Member

@paodb paodb commented Aug 15, 2023

Close #93

setEast(bounds.getNumber("east"));
}

public double getSouth() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use lombok @Getter and @Setter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lombok is not being used in the add-on. No need to replace setters/getters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Lombok is not being used in the project, maybe it would be a good idea to remove the dependency. The only problem that I see is that it is a transitive dependency so it might cause issues in projects, so it might be considered a breaking change, so I think that we could implement the removal of the dependency in another PR later.

}

@Override
public String toString() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotate the class with@ToString(includeFieldNames=true) instead. See https://projectlombok.org/features/ToString

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lombok is not being used in the add-on.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paodb paodb requested a review from flang August 22, 2023 13:05
Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this change. Regarding the lombok thing, we should create another ticket to discuss what to do.

@javier-godoy javier-godoy dismissed their stale review August 31, 2023 12:26

Review dismissed per #99 (review)

@javier-godoy javier-godoy merged commit a3fcfb2 into master Aug 31, 2023
5 checks passed
@javier-godoy javier-godoy deleted the issue-93 branch August 31, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Get coordinate bounds.
3 participants