Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on not working on Vaadin 24.4.0.alpha15 #104

Closed
paodb opened this issue Mar 20, 2024 · 12 comments · Fixed by #115
Closed

Add-on not working on Vaadin 24.4.0.alpha15 #104

paodb opened this issue Mar 20, 2024 · 12 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@paodb
Copy link
Member

paodb commented Mar 20, 2024

Latest version 2.2.1, is not working with Vaadin 24.4.0.alpha15

Browser console shows error:

image

@javier-godoy javier-godoy added the bug Something isn't working label Mar 20, 2024
@paodb
Copy link
Member Author

paodb commented Mar 20, 2024

I did more testing and it seems it all worked okay up until alpha5, the error started from alpha7 (there's no alpha6).

@javier-godoy
Copy link
Member

Is that error in development mode, production mode or both? Can you try alpha5 with intermediate Flow versions (alpha10 to alpha13)? Vaadin 24.4.0.alpha5 is based on Flow 24.4.0.alpha9 while Vaadin 24.4.0.alpha7 is based in Flow 24.4.0.alpha13,

@paodb
Copy link
Member Author

paodb commented Mar 21, 2024

Only tried dev mode, will try the other suggestions.

@paodb
Copy link
Member Author

paodb commented Mar 21, 2024

I did the test, with Vaadin 24.4.0.alpha5 and flow version from 24.4.0.alpha10 to 13 (and even 14) and it did not break. Tested both dev and prod mode.

@paodb
Copy link
Member Author

paodb commented Mar 21, 2024

Production mode error on browser from Vaadin 24.4.0.alpha7 to alpha16:

image

@sveinnetnordic
Copy link

sveinnetnordic commented Apr 15, 2024

Same error in 24.4.0.alpha22 using grid-exporter-addon 2.3.1

@sveinnetnordic
Copy link

In file: node_modules/@flowingcode/font-awesome-iron-iconset/far.js

If I remove import '@vaadin/icon/vaadin-icon.js'; on line 25 it works.

Hope this can help you to fix this!

@javier-godoy
Copy link
Member

In file: node_modules/@flowingcode/font-awesome-iron-iconset/far.js

If I remove import '@vaadin/icon/vaadin-icon.js'; on line 25 it works.

Hope this can help you to fix this!

Thanks. I'll look into it.

@sveinnetnordic
Copy link

sveinnetnordic commented Apr 18, 2024

Found this as a workaround:

<dependency>
           <groupId>com.flowingcode.addons</groupId>
           <artifactId>font-awesome-iron-iconset</artifactId>
           <version>5.2.2</version>
</dependency>

@javier-godoy
Copy link
Member

Good catch. I hadn't realized that version 2.x of this addon (which is compatible with Vaadin 24) depends on FA 4.x (which is compatible with Vaadin 23).

GridExporterAddon/pom.xml

Lines 152 to 154 in 3105a54

<groupId>com.flowingcode.addons</groupId>
<artifactId>font-awesome-iron-iconset</artifactId>
<version>4.2.0</version>

@sveinnetnordic
Copy link

I hope for a new release soon!

@paodb
Copy link
Member Author

paodb commented May 14, 2024

@sveinnetnordic please check new released version 2.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants