Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - JS function "execute" from node crashing the frontend and response is hidden #2589

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Bugfix - JS function "execute" from node crashing the frontend and response is hidden #2589

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e68aaec
Bugfix - Fix crash when executing JS function from node and fix hidde…
danieldabate Jun 6, 2024
596ff7b
add toString() to code executed result
HenryHengZJ Jun 6, 2024
a261645
Change height of CodeEditor to make it bigger, but still make the res…
danieldabate Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ui/src/ui-component/dialog/ExpandTextDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const ExpandTextDialog = ({ show, dialogProps, onCancel, onConfirm }) => {
useEffect(() => {
if (executeCustomFunctionNodeApi.error) {
if (typeof executeCustomFunctionNodeApi.error === 'object' && executeCustomFunctionNodeApi.error?.response?.data) {
setCodeExecutedResult(executeCustomFunctionNodeApi.error?.response?.data)
setCodeExecutedResult(JSON.stringify(executeCustomFunctionNodeApi.error?.response?.data, null, 2))
} else if (typeof executeCustomFunctionNodeApi.error === 'string') {
setCodeExecutedResult(executeCustomFunctionNodeApi.error)
}
Expand All @@ -100,15 +100,15 @@ const ExpandTextDialog = ({ show, dialogProps, onCancel, onConfirm }) => {
borderColor: theme.palette.grey['500'],
borderRadius: '12px',
height: '100%',
maxHeight: languageType === 'js' ? 'calc(100vh - 250px)' : 'calc(100vh - 220px)',
maxHeight: languageType === 'js' ? 'calc(100vh - 430px)' : 'calc(100vh - 400px)',
danieldabate marked this conversation as resolved.
Show resolved Hide resolved
overflowX: 'hidden',
backgroundColor: 'white'
}}
>
<CodeEditor
disabled={dialogProps.disabled}
value={inputValue}
height={languageType === 'js' ? 'calc(100vh - 250px)' : 'calc(100vh - 220px)'}
height={languageType === 'js' ? 'calc(100vh - 430px)' : 'calc(100vh - 400px)'}
theme={customization.isDarkMode ? 'dark' : 'light'}
lang={languageType}
placeholder={inputParam.placeholder}
Expand Down
Loading