Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Limit width of thumbnail image #149

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

grebaldi
Copy link
Member

@grebaldi grebaldi commented Nov 6, 2022

fixes: #147

before after
Screenshot_2022-11-04_11-34-39 Screenshot_2022-11-06_11-40-22

This PR simply adds a max-width to the thumbnail image, so it doesn't overflow its container.

@Sebobo Sebobo self-requested a review November 6, 2022 11:44
@Sebobo Sebobo added the Bug Something isn't working label Nov 6, 2022
@markusguenther
Copy link
Member

Can verify that the fix works. But MacOS Ventura seems to have privacy issues with testcafe, even with enabled permissions I can not run the e2e tests

Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally :)

@markusguenther
Copy link
Member

The failing e2e tests are not related to that change. Would it be OK for @Sebobo to merge this as it is?

@Sebobo Sebobo merged commit 2568e1f into Flowpack:master Nov 10, 2022
@Sebobo
Copy link
Member

Sebobo commented Nov 10, 2022

Thx guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Thumbnail overflows container in MediaSelectionScreen
3 participants