BUGFIX: Close clipboard screen when an asset source or asset collection gets selected #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: Flowpack#139 When the clipboard screen is open, it is still possible to select an asset source. But since the clipboard screen remains open, it seems as if nothing happened upon selecting the asset source. This commit closes the clipboard screen explicitly when an asset source is selected via the left sidebar.
refs: Flowpack#139 When the clipboard screen is open, it is still possible to select an asset collection. But since the clipboard screen remains open, it seems as if nothing happened upon selecting the asset collection. This commit closes the clipboard screen explicitly when an asset collection is selected via the left sidebar.
|
So, the E2E tests are failing and I can reproduce the error locally. It seems unrelated to this PR however, because the tests fail on |
|
Yes I think I broke something when I adjusted the Inspector a bit |
|
Would be nice to have a reducer to handle these actions, but for now it's fine like it is. Thx! |
Sebobo
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves: #139
The Problem
When the clipboard screen is open, it is still possible to select an asset source or an asset collection via the left side bar. But since the clipboard screen remains open, it seems as if nothing happened after the selection.
The Solution
I used the
clipboardVisibleStaterecoil state from@media-ui/feature-clipboardto explicitly close the clipboard screen whenever an asset source or an asset collection gets selected via the left side bar.