Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Make the tag select box to work with search field #216

Merged
merged 1 commit into from
Oct 31, 2023
Merged

FEATURE: Make the tag select box to work with search field #216

merged 1 commit into from
Oct 31, 2023

Conversation

soee
Copy link
Contributor

@soee soee commented Oct 26, 2023

What I did

The TagSelectBox component was modified to display search box.

How I did it

I have updated the MultiSelectBox component to enable the search option.

How to verify it

Open selected asset properties and use the search box under tags select list to search for tags.

Before:

image

After:
image

@soee soee mentioned this pull request Oct 26, 2023
Closed
@crydotsnake crydotsnake changed the title TASK: Make the tag select box to work with search field FEATURE: Make the tag select box to work with search field Oct 27, 2023
@crydotsnake crydotsnake added the Feature A new feature label Oct 27, 2023
@crydotsnake crydotsnake linked an issue Oct 27, 2023 that may be closed by this pull request
FEATURE: Allow search by tags like collections #203
Closed
@Sebobo
Copy link
Member

Sebobo commented Oct 31, 2023

Works perfectly, thx!
Will fix styling of the drop-down in a separate change.

@Sebobo Sebobo merged commit 198060f into Flowpack:main Oct 31, 2023
5 checks passed
@soee
Copy link
Contributor Author

soee commented Oct 31, 2023

Works perfectly, thx! Will fix styling of the drop-down in a separate change.

@Sebobo a lot of visual/styling issues will be gone when this #218 will be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebobo Sebobo Sebobo approved these changes

@crydotsnake crydotsnake Awaiting requested review from crydotsnake

Assignees
No one assigned
Labels
Feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: Allow search by tags like collections
3 participants
@soee @Sebobo @crydotsnake