Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix love not working right before Valentines day (VERY HIGHI priority) #1960

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#942
Original PR: tgstation/tgstation#81440

About The Pull Request

The parent new call is what handles showing the alt appearance to the mob

So we add the alt appearance to our date, try to show to any mob, it fails (there is no seer), then set seer

Fixes this by fixing the order

Changelog

🆑 Melbert
fix: You can once again see love on Valentines Day
/:cl:

… priority) (#942)

* Fix love not working right before Valentines day (VERY HIGHI priority) (#81440)

## About The Pull Request

The parent new call is what handles showing the alt appearance to the
mob

So we add the alt appearance to our date, try to show to any mob, it
fails (there is no seer), then set seer

Fixes this by fixing the order

## Changelog

:cl: Melbert
fix: You can once again see love on Valentines Day
/:cl:

* Fix love not working right before Valentines day (VERY HIGHI priority)

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
@ReezeBL ReezeBL merged commit eaf9f72 into master Feb 13, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-942 branch February 13, 2024 10:41
AnywayFarus added a commit that referenced this pull request Feb 13, 2024
Iajret pushed a commit that referenced this pull request Apr 18, 2024
…they are currently being repaired (#1960)

* dwawd

* womp

* woo

* Apply suggestions from code review

---------

Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
ReezeBL pushed a commit that referenced this pull request Apr 18, 2024
…they are currently being repaired (#1960) (#2946)

* dwawd

* womp

* woo

* Apply suggestions from code review

---------

Co-authored-by: nikothedude <59709059+nikothedude@users.noreply.github.com>
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants