[MIRROR] Spawners menu now displays the amount of uses left appropriately #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tely (#1006) * Spawners menu now displays the amount of uses left appropriately (#81496) ## About The Pull Request Prior to this PR, if an individual spawner allowed more than one uses, it would still display as one use in the menu. Not only that, but infinite spawners would also show as having just one use. Both of these behaviors have been fixed, resulting in a much more accurate depiction of how many uses are left on each spawner.  (The first spawner isn't normally infinite, I just used VV to edit its `infinite_uses` to `1` for the sake of proving that the display worked). ## Why It's Good For The Game Being able to know that a spawner is infinite is a good thing for players, just like being able to know how many uses are left if an individual spawner can be used by more than one player. ## Changelog :cl: GoldenAlpharex fix: The Spawners menu now accurately displays the amount of uses left in each spawner option, taking into account individual spawners that either allow more than one use, or an infinite amount of uses. /:cl: * Spawners menu now displays the amount of uses left appropriately --------- Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Feb 17, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Birdshot: engi wardrope. (#82639) ## About The Pull Request Add engi wardrope on Birdshot. ## Why It's Good For The Game Birdshot doesn't have engi wardrope. :cl: fix: Birdshot now have engi wardrope /:cl: * Birdshot: engi wardrope. --------- Co-authored-by: Xackii <120736708+Xackii@users.noreply.github.com>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Birdshot: engi wardrope. (#82639) ## About The Pull Request Add engi wardrope on Birdshot. ## Why It's Good For The Game Birdshot doesn't have engi wardrope. :cl: fix: Birdshot now have engi wardrope /:cl: * Birdshot: engi wardrope. --------- Co-authored-by: NovaBot <154629622+NovaBot13@users.noreply.github.com> Co-authored-by: Xackii <120736708+Xackii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1006
Original PR: tgstation/tgstation#81496
About The Pull Request
Prior to this PR, if an individual spawner allowed more than one uses, it would still display as one use in the menu. Not only that, but infinite spawners would also show as having just one use. Both of these behaviors have been fixed, resulting in a much more accurate depiction of how many uses are left on each spawner.
(The first spawner isn't normally infinite, I just used VV to edit its
infinite_usesto1for the sake of proving that the display worked).Why It's Good For The Game
Being able to know that a spawner is infinite is a good thing for players, just like being able to know how many uses are left if an individual spawner can be used by more than one player.
Changelog
🆑 GoldenAlpharex
fix: The Spawners menu now accurately displays the amount of uses left in each spawner option, taking into account individual spawners that either allow more than one use, or an infinite amount of uses.
/:cl: