Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use recent API consistently. #131

Open
tomusdrw opened this issue Oct 22, 2024 · 0 comments
Open

Use recent API consistently. #131

tomusdrw opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request prio-low

Comments

@tomusdrw
Copy link
Contributor

The tool should use the latest API to interact with the PVM.

As of 2024-10-22, the polkavm package supports both APIs, typeberry still need to switch (CC @mateuszsikora).

I mean specifically:

  1. resetGeneric as defined in Supporting external PVMs #81 instead of currently used reset.
  2. setNextProgramCounter and setGasLeft instead of resume.
@tomusdrw tomusdrw added enhancement New feature or request prio-low labels Oct 22, 2024
@tomusdrw tomusdrw changed the title Use recent API consitently. Use recent API consistently. Nov 9, 2024
@tomusdrw tomusdrw mentioned this issue Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request prio-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomusdrw