Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Basic blocks support #238

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Initial Basic blocks support #238

merged 2 commits into from
Dec 6, 2024

Conversation

tomusdrw
Copy link
Contributor

@tomusdrw tomusdrw commented Dec 6, 2024

Related: #237
Related: #131

  1. Initial support for basic blocks (displaying block boundaries)
  2. Remove manual type definitions and use types from the pvm-debugger-adapter package
  3. Clean up typeberry API and make it more consistent with other PVMS and Supporting external PVMs #81

@netlify Netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

✅ Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit c984e97
🔍 Latest deploy log https://app.netlify.com/sites/pvm-debugger/deploys/6752f6f14f67a30008a08e1f
😎 Deploy Preview https://deploy-preview-238--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

krystian50
krystian50 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@krystian50 krystian50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would consider more gentle colour diff between even/odd blocks. The gray could be a bit lighter.

@tomusdrw
Copy link
Contributor Author

tomusdrw commented Dec 6, 2024

@krystian50 feel free to change it to a different color that you like.

@tomusdrw tomusdrw merged commit 0bf79b4 into main Dec 6, 2024
6 checks passed
@tomusdrw tomusdrw deleted the td-bblocks branch December 6, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystian50 krystian50 krystian50 approved these changes

@wkwiatek wkwiatek Awaiting requested review from wkwiatek

@mateuszsikora mateuszsikora Awaiting requested review from mateuszsikora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomusdrw @krystian50