Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual trap at the end of the program #141

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix virtual trap at the end of the program #141

merged 1 commit into from
Oct 25, 2024

Conversation

wkwiatek
Copy link
Collaborator

@wkwiatek wkwiatek commented Oct 25, 2024

Fixes #139

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit d97a270
🔍 Latest deploy log https://app.netlify.com/sites/pvm-debugger/deploys/671b6d6c78c7e70008b1fd41
😎 Deploy Preview https://deploy-preview-141--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomusdrw
Copy link
Contributor

image The branch code halts on the branch itself, which doesn't seem to be correct. Not sure if this is caused by this PR or something else. @mateuszsikora maybe take a look too.

@tomusdrw
Copy link
Contributor

Okay, it only happens after I loaded fib example first, so might be fixed by https://github.com/FluffyLabs/typeberry/pull/161 (i.e. issue with jump table).

@wkwiatek
Copy link
Collaborator Author

@tomusdrw I believe this is exactly the case. Also reported here: #140

@wkwiatek wkwiatek merged commit 0f71699 into main Oct 25, 2024
6 checks passed
@wkwiatek wkwiatek deleted the fix-end-run branch October 25, 2024 14:45
@krystian50
Copy link
Contributor

@wkwiatek does it fix the #140? Could you close the issue if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step allows to reset the state
3 participants