Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #142

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Error handling #142

merged 3 commits into from
Oct 27, 2024

Conversation

krystian50
Copy link
Contributor

No description provided.

@krystian50 krystian50 marked this pull request as draft October 25, 2024 11:09
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit 76e075a
🔍 Latest deploy log https://app.netlify.com/sites/pvm-debugger/deploys/671dffdf7c472600082ab83c
😎 Deploy Preview https://deploy-preview-142--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@wkwiatek wkwiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

const state = getState() as RootState;
const worker = state.workers.find((worker) => worker.id === id);
const debuggerState = state.debugger;
// export const initWorker = createAsyncThunk("workers/initWorker", async (id: string, { getState }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if still needed - if not - let's remove it.

@krystian50 krystian50 marked this pull request as ready for review October 27, 2024 08:56
@krystian50 krystian50 merged commit d83b90d into main Oct 27, 2024
5 of 6 checks passed
@krystian50 krystian50 deleted the error-handling branch October 27, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants