Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVM select refactor #143

Merged
merged 9 commits into from
Oct 28, 2024
Merged

PVM select refactor #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5d924e
PVM select refactor
wkwiatek Oct 23, 2024
0653fd6
Change PVMs select to required; change the label
wkwiatek Oct 27, 2024
7a9f118
Allow to update multiple instances of the same filename / url without…
wkwiatek Oct 27, 2024
75e54b7
Improve pvm comparison tooltip
wkwiatek Oct 27, 2024
659f4fe
Make Rust default option in selector
wkwiatek Oct 28, 2024
d32e676
Change select label
wkwiatek Oct 28, 2024
47a636c
Metadata fetch error handling
wkwiatek Oct 28, 2024
eb1d95b
Adjust end to end tests
wkwiatek Oct 28, 2024
ad787de
Merge branch 'main' into pvm-select
wkwiatek Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,55 +219,55 @@ function App() {
);

await Promise.all(
selectedPvms.map(async ({ value, type, param }) => {
logger.info("Selected PVM type", type, param);
selectedPvms.map(async ({ id, type, params }) => {
logger.info("Selected PVM type", id, type, params);

if (workers.find((worker: WorkerState) => worker.id === type)) {
if (workers.find((worker: WorkerState) => worker.id === id)) {
logger.info("Worker already initialized");
// TODO: for now just initialize the worker one more time
}
logger.info("Worker not initialized");

if (value === AvailablePvms.WASM_FILE) {
await dispatch(createWorker(AvailablePvms.WASM_FILE)).unwrap();
if (id === AvailablePvms.POLKAVM) {
await dispatch(createWorker(AvailablePvms.POLKAVM)).unwrap();
await dispatch(
loadWorker({
id: AvailablePvms.WASM_FILE,
id,
payload: {
type: PvmTypes.WASM_FILE,
params: typeof param !== "string" ? { file: param.file, lang: param.lang } : undefined,
type: PvmTypes.WASM_URL as PvmTypes,
params,
},
}),
).unwrap();
} else if (value === AvailablePvms.WASM_URL) {
await dispatch(createWorker(AvailablePvms.WASM_URL)).unwrap();
} else if (id === AvailablePvms.TYPEBERRY) {
await dispatch(createWorker(AvailablePvms.TYPEBERRY)).unwrap();
await dispatch(
loadWorker({
id: AvailablePvms.WASM_URL,
id,
payload: {
type: PvmTypes.WASM_URL,
params: { url: param as string },
type: PvmTypes.BUILT_IN,
},
}),
).unwrap();
} else if (value === AvailablePvms.POLKAVM) {
await dispatch(createWorker(AvailablePvms.POLKAVM)).unwrap();
} else if (type === AvailablePvms.WASM_FILE) {
await dispatch(createWorker(id)).unwrap();
await dispatch(
loadWorker({
id: AvailablePvms.POLKAVM,
id,
payload: {
type: PvmTypes.WASM_URL as PvmTypes,
params: { url: param as string },
type: PvmTypes.WASM_FILE,
params,
},
}),
).unwrap();
} else if (value === AvailablePvms.TYPEBERRY) {
await dispatch(createWorker(AvailablePvms.TYPEBERRY)).unwrap();
} else if (type === AvailablePvms.WASM_URL) {
await dispatch(createWorker(id)).unwrap();
await dispatch(
loadWorker({
id: AvailablePvms.TYPEBERRY,
id,
payload: {
type: type as PvmTypes,
type: PvmTypes.WASM_URL,
params,
},
}),
).unwrap();
Expand Down
Loading
Loading