Revert "Host calls cleanup" #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78fde84.
krystian50
added a commit
that referenced
this pull request
Jan 8, 2025
* refactor steps state * Add host call example * Add host calls component * Add write host-call * Add host calls to pvm * Add host calls to pvm * change service id * Do not stop debugger on host call * Show host call popup when status is HOST; move logic to separated worker message * Ensure run is working properly * Fix linter * refactor * Host calls cleanup (#251) * Fix multi-PVM visual glitch (#241) * Don't perform multiple steps when Stepping in the UI. (#240) * Fix multi-PVM visual glitch (#243) * Modify program editor to be available only in edit mode; improve error handling (#242) * Move program code input to edit mode * Handle errors in program text editor * Allow for hex in array as a program input * Fix linter * refactor --------- Co-authored-by: Wojciech Kwiatek <wojtek.kwiatek@gmail.com> Co-authored-by: Tomek Drwięga <tomusdrw@users.noreply.github.com> * Revert "Host calls cleanup (#251)" (#252) This reverts commit 78fde84. * Add trie inputs * Add trie input * fix hex val and empty key * Store write host call data * format valueblob * fix write host call * Change layout * workarounds for other pvms * Fix object freeze issue * fix error handling * remove unused files * remove comments * remove comments * Add service id * no error fo empty storage record * change pvm generated hash * fix lint * fix batched steps * fix continue after host call * fix type error * Move setting service id * Change set service id --------- Co-authored-by: Wojciech Kwiatek <wojtek.kwiatek@gmail.com> Co-authored-by: Tomek Drwięga <tomusdrw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #251