Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new codec link #308

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add new codec link #308

merged 2 commits into from
Jan 24, 2025

Conversation

krystian50
Copy link
Contributor

fix #272

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit aa2ebca
🔍 Latest deploy log https://app.netlify.com/sites/pvm-debugger/deploys/6793a1ba243cd60008b071e1
😎 Deploy Preview https://deploy-preview-308--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krystian50 krystian50 requested a review from tomusdrw January 24, 2025 13:38
@@ -238,7 +244,7 @@ function MemoryRangeRow({
</PopoverTrigger>
<PopoverContent className="w-auto p-2">
<a
href={`https:codec.fluffylabs.dev?memory=${flatData}&numeralSystem=dec`}
href={`https://papi.fluffylabs.dev/?data=${unt8ToHex(flatData)}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the lack of // in the previous href. Was it a bug or does it maybe have to be like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a bug

@krystian50 krystian50 merged commit bc9d324 into main Jan 24, 2025
6 checks passed
@krystian50 krystian50 deleted the integrate-with-codec branch January 24, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory ranges - Should cross-link to CODEC tool
2 participants