Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI builds #1435

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix CI builds #1435

wants to merge 6 commits into from

Conversation

derselbst
Copy link
Member

This PR fixes the Android CI build and it (almost) fixes the Windows CI build. It also fixes fluidsynth's build on Windows XP and older.

There is one remaining issue: If a depending software package (that fluidsynth discovers via pkg-config) depends on libsndfile, fluidsynth will try to find a matching sndfile.pc file, but fails to do so, because libsndfile currently doesn't distribute them in their official Windows binary builds:
https://github.com/libsndfile/libsndfile/blob/0d3f80b7394368623df558d8ba3fee6348584d4d/.github/workflows/action.yml#L173

This will then result in the following error:
https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=11000&view=results

I currently have no explanation why this only affects the x86 while the x64 build works fine. The requirement for sndfile originates from libinstpatch's .pc file, and there sndfile is clearly marked as a requirement for both x86 and x64 builds.

@pedrolcl Do you have an idea how to fix or workaround that issue? Any idea why libsndfile has explicitly disabled installing the pkg-config file? Else I would ask them to change it.

Fixes #1422

@derselbst derselbst added this to the 2.4 milestone Nov 17, 2024
Copy link

sonarcloud bot commented Nov 17, 2024

@pedrolcl
Copy link
Contributor

pedrolcl commented Nov 17, 2024

Do you have an idea how to fix or workaround that issue?

You may disable libinstpatch for building this scenario. The problem may be in cmake_admin/FindInstPatch.cmake or in libinstpatch itself.

Any idea why libsndfile has explicitly disabled installing the pkg-config file? Else I would ask them to change it.

I remember requesting Erik to include the .pc file in the windows .zip package a long time ago. But since he left the project the new maintainers seem clueless, and this case in particular seems like an ideological decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build Fluidsynth with libsndfile on Windows.
2 participants