Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of renaming FlutterGen? #53

Closed
wasabeef opened this issue Nov 14, 2020 · 7 comments
Closed

Discussion of renaming FlutterGen? #53

wasabeef opened this issue Nov 14, 2020 · 7 comments
Labels
discussion Want to discuss it help wanted Extra attention is needed
Milestone

Comments

@wasabeef
Copy link
Member

wasabeef commented Nov 14, 2020

Please read this #49.

This package has exactly the same name as the official Flutter Localization package, so there is a name conflict. Therefore, the official L10n (Flutter 1.22 +) and build_runner of FlutterGen cannot be used at the same time.
*Dart CLI and Homebrew are fine.

We now have these options available.

  • Just minor change the pub.dev namespace => 😄
  • Don't support build_runner => 🎉
  • Rebranding and re-register to pub.dev (... need ideas..) => 🚀

Please vote...

@wasabeef wasabeef added discussion Want to discuss it help wanted Extra attention is needed labels Nov 14, 2020
@wasabeef wasabeef pinned this issue Nov 24, 2020
@vintage
Copy link

vintage commented Nov 30, 2020

Ideally we should support the build_runner - using it in all the projects to perform auto generations provided by few other libs (like freezed or json_serializable). Appreciate the fact that all of the generation can be done by simply calling build_runner and no additional steps are required in the CI config (even if it's only about adding one new call).

As the flutter_gen is about assets generation, maybe ... genset?

@dudeck
Copy link

dudeck commented Dec 8, 2020

I'm also totally for changing the name of this library. I think it will be the easiest and proper solution with no error prones.

@mark-nicepants
Copy link

In favor of renaming and republishing:

Names for inspiration:

  • assets_gen
  • safe_assets
  • r_flutter (For those who are used to the R file in Android development)
  • type_safe_assets

@andreadelfante
Copy link

andreadelfante commented Jan 15, 2021

  • r_flutter

It would be a great name! 😄

@wasabeef wasabeef added this to the 2.0.0 milestone Feb 18, 2021
@wasabeef
Copy link
Member Author

@vintage @dudeck @mark-apn @andreadelfante and guys.

I'm sorry for the late reply and decisions.

We decided how solves it.

for commands

$ brew install FlutterGen/tap/fluttergen
or
$ dart pub global activate flutter_gen

$ fluttergen -c pubspec.yaml

for build runner

dev_dependencies:
  build_runner: 
  flutter_gen_runner: ^3.0.2

@LeonardoRosaa
Copy link

I'm facing this issue with the Flutter 3.19.5.

@Hackmodford
Copy link

I'm facing this issue with Flutter 3.22.0, I had to revert back to 3.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Want to discuss it help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants