Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.x.x split packages #80

Merged
merged 12 commits into from
Feb 19, 2021
Merged

v2.x.x split packages #80

merged 12 commits into from
Feb 19, 2021

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Feb 17, 2021

What does this change?

Split for build_runner and command-lines.

For Command-line

  • dir:packages/command
  • pub.dev: flutter_gen

Just as usual.

$ brew install FlutterGen/tap/fluttergen
$ dart pub global activate flutter_gen

For Build Runner

  • dir: packages/runner
  • pub.dev: flutter_gen_runner

New package.

dev_dependencies:
  build_runner:
  flutter_gen_runner: ^2.0.0

Common Package (Core)

  • dir: packages/core
  • pub.dev: flutter_gen_core *unlisted.

What is the value of this and can you measure success?

Pass #53

@wasabeef wasabeef changed the title [WIP] split packages [WIP] Split for build_runner and for command-lines Feb 17, 2021
@wasabeef wasabeef changed the title [WIP] Split for build_runner and for command-lines [WIP] split packages v2.x.x Feb 17, 2021
@wasabeef wasabeef changed the title [WIP] split packages v2.x.x [WIP] v2.x.x split packages Feb 17, 2021
@wasabeef wasabeef added this to the 2.0.0 milestone Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #80 (445b640) into main (dcf8a0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          16       16           
  Lines         506      506           
=======================================
  Hits          497      497           
  Misses          9        9           
Impacted Files Coverage Δ
packages/core/lib/flutter_generator.dart 93.54% <ø> (ø)
packages/core/lib/generators/assets_generator.dart 100.00% <ø> (ø)
packages/core/lib/generators/colors_generator.dart 98.21% <ø> (ø)
packages/core/lib/generators/fonts_generator.dart 100.00% <ø> (ø)
packages/core/lib/generators/generator_helper.dart 100.00% <ø> (ø)
...lib/generators/integrations/flare_integration.dart 100.00% <ø> (ø)
...e/lib/generators/integrations/svg_integration.dart 100.00% <ø> (ø)
packages/core/lib/settings/asset_type.dart 96.87% <ø> (ø)
packages/core/lib/settings/color_path.dart 100.00% <ø> (ø)
packages/core/lib/settings/config.dart 100.00% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b0ad1...445b640. Read the comment docs.

@wasabeef wasabeef requested a review from lcdsmao February 18, 2021 18:04
@wasabeef wasabeef changed the title [WIP] v2.x.x split packages v2.x.x split packages Feb 18, 2021
Copy link
Member

@lcdsmao lcdsmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should modify comment in packages/core/lib/settings/pubspec.dart

_internal/build.yaml Outdated Show resolved Hide resolved
@wasabeef wasabeef requested a review from lcdsmao February 19, 2021 05:26
Copy link
Member

@lcdsmao lcdsmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wasabeef wasabeef merged commit 08f34be into main Feb 19, 2021
@wasabeef wasabeef deleted the flutter-gen-runner branch February 19, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants