Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose theme parameter of SvgPicture #199

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

mj-hd
Copy link
Contributor

@mj-hd mj-hd commented Mar 3, 2022

What does this change?

  • expose theme parameter of SvgPicture

This is useful to specify svg's currentColor property recently supported by flutter_svg.

SvgTheme class

@mj-hd mj-hd marked this pull request as ready for review March 3, 2022 08:13
@lcdsmao lcdsmao requested a review from wasabeef March 7, 2022 01:23
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #199 (25e30ec) into main (66e3515) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          19       19           
  Lines         574      574           
=======================================
  Hits          568      568           
  Misses          6        6           
Impacted Files Coverage Δ
...e/lib/generators/integrations/svg_integration.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e3515...25e30ec. Read the comment docs.

@wasabeef wasabeef added this to the 4.1.6 milestone Mar 7, 2022
@wasabeef wasabeef merged commit 44d1e6e into FlutterGen:main Mar 7, 2022
@wasabeef
Copy link
Member

wasabeef commented Mar 7, 2022

@mj-hd
Thank you

@wasabeef wasabeef mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants