-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vector graphics (vec files) in SvgGenImage #493
Conversation
Any sort of timeline when this will get merged? |
@raldhafiri Thanks for the contribution! AFAICT this change doesn't require users to update their usages, correct? |
yes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 22 22
Lines 771 772 +1
=======================================
+ Hits 750 751 +1
Misses 21 21 ☔ View full report in Codecov by Sentry. |
Looks like your latest changes are based on an old commit. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and keeping this up-to-date. It requires the last branch update.
Why the assets name have |
What does this change?
Integrate vector_graphic in the generation process alongside flutter_svg and allow to user to configure vector_graphic as we configure flutter_svg currently. And therefore add the generation of the .vec optimized file of the SVG in the process of generation of the differents assets dart file with the supports of VectorGraphic widget instead of SvgPicture.
Fixes #362 🎯
Type of change