Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vector graphics (vec files) in SvgGenImage #493

Merged
merged 10 commits into from
May 6, 2024

Conversation

raldhafiri
Copy link
Contributor

What does this change?

Integrate vector_graphic in the generation process alongside flutter_svg and allow to user to configure vector_graphic as we configure flutter_svg currently. And therefore add the generation of the .vec optimized file of the SVG in the process of generation of the differents assets dart file with the supports of VectorGraphic widget instead of SvgPicture.

Fixes #362 🎯

Type of change

  • New feature (non-breaking change which adds functionality)

@Kypsis
Copy link

Kypsis commented Apr 15, 2024

Any sort of timeline when this will get merged?

@AlexV525
Copy link
Member

@raldhafiri Thanks for the contribution! AFAICT this change doesn't require users to update their usages, correct?

@raldhafiri
Copy link
Contributor Author

@raldhafiri Thanks for the contribution! AFAICT this change doesn't require users to update their usages, correct?

yes

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (187cb49) to head (e31cd27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          22       22           
  Lines         771      772    +1     
=======================================
+ Hits          750      751    +1     
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raldhafiri raldhafiri requested a review from AlexV525 April 28, 2024 10:57
@AlexV525
Copy link
Member

Looks like your latest changes are based on an old commit. :)

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and keeping this up-to-date. It requires the last branch update.

@AlexV525 AlexV525 merged commit 6160667 into FlutterGen:main May 6, 2024
5 checks passed
@wasabeef wasabeef added this to the 5.5.0+1 milestone May 20, 2024
@myxzlpltk
Copy link

Why the assets name have Svg suffix like notFoundSvg? I know because file extension is .svg.vec. Can we automatically rename it? Because that extension come straight from vector_graphics_compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Support for vector_graphic directly
5 participants