⚡️ Enables gaplessPlayback by default for image assets
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 24 24
Lines 860 860
=======================================
Hits 839 839
Misses 21 21 ☔ View full report in Codecov by Sentry. |
AlexV525
commented
Sep 7, 2024
| @@ -57,7 +57,7 @@ ${isPackage ? "\n static const String package = '$packageName';" : ''} | |||
| ImageRepeat repeat = ImageRepeat.noRepeat, | |||
| Rect? centerSlice, | |||
| bool matchTextDirection = false, | |||
| bool gaplessPlayback = false, | |||
There was a problem hiding this comment.
The core change of the request.
Merged
wasabeef
pushed a commit
that referenced
this pull request
Oct 8, 2024
## 5.8.0 **Feature** - [#555](#555) Support build.yaml to configure. by [@b2nkuu](https://github.com/b2nkuu) - [#567](#567) Generate the `package` constant for generated font classes. by [@TesteurManiak](https://github.com/TesteurManiak) - [#569](#569) Enables `gaplessPlayback` by default for image assets. by [@AlexV525](https://github.com/AlexV525) - [#580](#580) Allows `mime: '>=1.0.0 <3.0.0'`. by [@AlexV525](https://github.com/AlexV525) **Development** - [#563](#563) Fix concurrency execution with melos. by [@wasabeef](https://github.com/wasabeef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Image assets are finalized during builds, they cannot be changed during the runtime. The
gaplessPlaybackdefaults tofalsewhich might lead to images flashing between routes when the provider changes, which it doesn't in fact.Now we change it to
trueto ignore changes to provide a good display experience. This can also considered as a non-breaking change in most cases.Type of change