move to CUDA.jl #1258
Merged
move to CUDA.jl #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
|
bors r+ |
|
Build failed: |
|
I would recommend pushing to that branch directly rather than have multiple prs do the same thing. I can give you commit bit on that |
|
bors r+ |
yeah, I wasn't sure how to do that since that branch is on your personal fork. This is on the original repo, so you should already be able to push to it |
|
@maleadt I observe julia> using Flux
┌ Warning: `haskey(::TargetIterator, name::String)` is deprecated, use `Target(; name = name) !== nothing` instead.
│ caller = llvm_compat(::VersionNumber) at compatibility.jl:181
└ @ CUDA ~/.julia/packages/CUDA/42B9G/deps/compatibility.jl:181here. If |
|
Build failed: |
|
bors r+ |
|
Why remove the doctest? |
|
Build succeeded: |
This was referenced Jul 2, 2020
Closed
bors bot
added a commit
that referenced
this pull request
Jul 2, 2020
1261: reinstate curnn test r=CarloLucibello a=CarloLucibello this is passing locally on my GPU, but in #1258 bors didn't seem to like it. Let's try again EDIT: actually this is not passing test locally, but let's see what BORS says in any case cfr #1262 Co-authored-by: CarloLucibello <carlo.lucibello@gmail.com>
This was referenced Jul 2, 2020
Closed
bors bot
added a commit
that referenced
this pull request
Sep 16, 2020
1261: reinstate curnn test r=DhairyaLGandhi a=CarloLucibello this is passing locally on my GPU, but in #1258 bors didn't seem to like it. Let's try again EDIT: actually this is not passing test locally, but let's see what BORS says in any case cfr #1262 Co-authored-by: CarloLucibello <carlo.lucibello@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing #1204