-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cat
#156
Add support for cat
#156
Conversation
Looks good! You don't need a new |
Thanks, @MikeInnes! Fixed it. |
Ok so two comments on this: (1) You can avoid array allocations (and type instability) by working with tuples for |
Oh, and here's a test case that fails: |
86ae1fa
to
d222700
Compare
027a922
to
5cc6813
Compare
Co-authored-by: americast <sayan.sinha@iitkgp.ac.in>
Co-authored-by: americast <sayan.sinha@iitkgp.ac.in>
Merged with #243 -- thanks 👍 |
Co-authored-by: americast <sayan.sinha@iitkgp.ac.in>
@MikeInnes Adds generic
cat
to Flux. Fixes #142.The tests have been provided separately for
cat
as it needs a parameter which is not tracked.