Revert #1557 temporarily #1560
Closed
Revert #1557 temporarily #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the reversion wasn't committed. I also agree we should revert, there was a change of behavior there which didn't seem sane |
Merged
|
My mistake; closing in favor of #1561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes from #1557. I think some of those changes are good, but there were some reservations expressed. Since the changes aren't pressing, let's discuss them instead. We can merge this PR to revert, then open another for the changes from #1557.
PR Checklist
Tests are addedEntry in NEWS.mdDocumentation, if applicableAPI changes require approval from a committer (different from the author, if applicable)