Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add token secret for codecov #1845

Merged
merged 1 commit into from
Jan 22, 2022
Merged

add token secret for codecov #1845

merged 1 commit into from
Jan 22, 2022

Conversation

ToucheSir
Copy link
Member

This should resolve the (non-terminating) upload errors on CI and actually let us collect coverage info.

This should resolve the (non-terminating) upload errors on CI and actually let us collect coverage info.
@ToucheSir ToucheSir mentioned this pull request Jan 22, 2022
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so secret :) but I guess you know what you are doing, it's got to write somewhere...

@ToucheSir
Copy link
Member Author

I was pointed to the docs at https://github.com/JuliaGPU/buildkite#using-secrets, and presumably those folks know what they're doing 😄

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2de00fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1845   +/-   ##
=========================================
  Coverage          ?   74.33%           
=========================================
  Files             ?       28           
  Lines             ?     1652           
  Branches          ?        0           
=========================================
  Hits              ?     1228           
  Misses            ?      424           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de00fc...d6d4659. Read the comment docs.

@ToucheSir ToucheSir merged commit 6cd2bf7 into master Jan 22, 2022
@ToucheSir ToucheSir deleted the bc/codecov-token branch January 22, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants