Depend on Optimisers.jl #1864
Merged
Depend on Optimisers.jl #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Feb 5, 2022
| @@ -1,12 +1,14 @@ | |||
| module Flux | |||
|
|
|||
| # Zero Flux Given | |||
There was a problem hiding this comment.
I'd totally forgotten about this line 😆
cossio
approved these changes
Feb 6, 2022
src/Flux.jl
Outdated
| @reexport using NNlib | ||
|
|
||
| using Zygote |
There was a problem hiding this comment.
Can this can go away (given the line just below)?. Or at least replaced by an import.
There was a problem hiding this comment.
Actually to remove using Zygote one needs to replace also Flux.withgradient with Zygote.withgradient in the recurrent.jl tests for tests to pass.
There was a problem hiding this comment.
I think this could be better served by a separate PR that does some general import cleanup.
|
Optimisers.jl 0.2 is now tagged. |
darsnack
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is I think the minimal step to make Flux usable with Optimisers.jl: Both should see the same function
trainable.Will fail until Optimisers.jl 0.2 is tagged; 0.1 does not have this function.
If we aren't deleting implicit parameters from v0.13, can we do any more than this? Maybe we can allow
setup(opt, ::Params), and write anupdate!which uses that. But this PR does not do it.Xref #1481, which completely replaces Flux's code, and I think