Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OperatorLearning.jl to Flux downstream tests #1869

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

ChrisRackauckas
Copy link
Member

This will be a more "Flux intensive" SciML repo than some of the others so I think it will be good to hear early and often about Flux changes there.

CC @pzimbrod

This will be a more "Flux intensive" SciML repo than some of the others so I think it will be good to hear early and often about Flux changes there.

CC @pzimbrod
@github-actions
Copy link
Contributor

Once the build has completed, you can preview any updated documentation at this URL: https://fluxml.ai/Flux.jl/previews/PR1869/ in ~20 minutes

@darsnack darsnack merged commit 0b7e1b6 into master Feb 10, 2022
@mcabbott
Copy link
Member

I'm not sure this is running correctly, but don't see why. https://github.com/FluxML/Flux.jl/actions/runs/1824724204 shows this:

Screenshot 2022-02-10 at 11 14 56

@darsnack
Copy link
Member

I don't know why GHA does it this way, but there's a separate "downstream" section that does have the tests. Looks like it ran correctly: https://github.com/FluxML/Flux.jl/actions/runs/1824525398

@mcabbott mcabbott deleted the ChrisRackauckas-patch-1 branch March 7, 2022 16:39
@mcabbott
Copy link
Member

mcabbott commented Mar 7, 2022

This will need updates for Flux 0.13 BTW, as params is no longer exported:

parameters: Error During Test at /home/runner/work/Flux.jl/Flux.jl/downstream/test/fourierlayer.jl:22
[342](https://github.com/FluxML/Flux.jl/runs/5451760884?check_suite_focus=true#step:6:342)
  Test threw exception
[343](https://github.com/FluxML/Flux.jl/runs/5451760884?check_suite_focus=true#step:6:343)
  Expression: size((params(FourierLayer(128, 64, 100, 20)))[4]) == (1, 64, 100)
[344](https://github.com/FluxML/Flux.jl/runs/5451760884?check_suite_focus=true#step:6:344)
  UndefVarError: params not defined
[345](https://github.com/FluxML/Flux.jl/runs/5451760884?check_suite_focus=true#step:6:345)

(Also, I think 70b4b5a might cure the downstream test weirdness.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants