Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for MLUtils to 0.2, (keep existing compat) #1889

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the MLUtils package from 0.1.4 to 0.1.4, 0.2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #1889 (345c8e4) into master (57ef5c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1889   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files          19       19           
  Lines        1434     1434           
=======================================
  Hits         1232     1232           
  Misses        202      202           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ef5c0...345c8e4. Read the comment docs.

Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but is there any reason to keep 0.1 compat?

Not new to this, but lots of dep. warnings from tests here:

┌ Warning: `unsqueeze(x::AbstractArray, dims::Int)` is deprecated, use `unsqueeze(x; dims = dims)` instead.
--
  | │   caller = macro expansion at Test.jl:445 [inlined]
  | └ @ Core /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Test/src/Test.jl:445
  | ┌ Warning: `stack(x, dims)` is deprecated, use `stack(x; dims = dims)` instead.
  | │   caller = macro expansion at utils.jl:249 [inlined]
  | └ @ Core /var/lib/buildkite-agent/builds/gpuci-14/julialang/flux-dot-jl/test/utils.jl:249

@CarloLucibello CarloLucibello merged commit a67d184 into master Feb 28, 2022
@CarloLucibello CarloLucibello deleted the compathelper/new_version/2022-02-24-00-13-51-919-01190803842 branch April 7, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants