Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain stride≠1 case for SamePad #1965

Merged
merged 1 commit into from
May 17, 2022

Conversation

KronosTheLate
Copy link
Contributor

This PR adds a line to explain what SamePad() does when stride is not equal to 1.

This PR adds a line to explain what `SamePad()` does when stride is not equal to 1.
@codecov-commenter
Copy link

Codecov Report

Merging #1965 (3885807) into master (2606e64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1965   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          19       19           
  Lines        1485     1485           
=======================================
  Hits         1306     1306           
  Misses        179      179           
Impacted Files Coverage Δ
src/layers/conv.jl 88.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2606e64...3885807. Read the comment docs.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ToucheSir ToucheSir merged commit 1f82da4 into FluxML:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants