Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piratical errors for two mistakes #1976

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

mcabbott
Copy link
Member

Closes #1974, closes FluxML/Optimisers.jl#76

Both commit piracy, as MLUtils doesn't depend on Functors, and Optimisers doesn't depend on Zygote. Wouldn't be so hard to fix #1974 without piracy, but this is simple.

@ToucheSir
Copy link
Member

I suggested this and am naturally in favour of it, but if there are objections now is the time :)

@CarloLucibello
Copy link
Member

Seems the simplest thing to do

@mcabbott mcabbott merged commit b6b3569 into FluxML:master May 30, 2022
@mcabbott mcabbott deleted the friendly_errors branch May 30, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make gpu(::DataLoader) work or error loudly if it doesn't Applying Grads fails
3 participants