-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in docs #2030
Fix typo in docs #2030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is something I and others have wanted to do for a while but left as low priority, so it's great that you tackled it. I think the docs copy in general could use some wordsmithing, but that need not be addressed in this PR.
I've just taken the opportunity to touch up some existing grammatical awkwardness in the changed docs. If everything jives with you, we can merge.
Yes, absolutely - it looks much better! I didn’t dare to change it too much, because different people have different styles and I didn’t want to step on any toes. |
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, thanks!
As part of the JuliaCon hackathon, I have fixed some typos I noticed in the docs and ran a few of the files through Grammarly.
There were no changes to the active code (only docs).
I'm happy to withdraw this PR if it's not helpful.