Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unthunk in some rules #2058

Merged
merged 3 commits into from
Sep 4, 2022
Merged

unthunk in some rules #2058

merged 3 commits into from
Sep 4, 2022

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Sep 4, 2022

First commit is what's needed, with JuliaDiff/ChainRules.jl#673 and JuliaDiff/Diffractor.jl#89, to get Diffractor working on Metalhead.ResNet(18).

Other commits are the result of searching for rrule here.

@codecov-commenter
Copy link

Codecov Report

Merging #2058 (e4c650f) into master (31e4dd0) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #2058   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          18       18           
  Lines        1357     1357           
=======================================
  Hits         1170     1170           
  Misses        187      187           
Impacted Files Coverage Δ
src/functor.jl 87.93% <50.00%> (ø)
src/cuda/cudnn.jl 100.00% <100.00%> (ø)
src/layers/recurrent.jl 90.09% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mcabbott mcabbott merged commit d214600 into master Sep 4, 2022
@mcabbott mcabbott deleted the mcabbott-patch-1 branch September 4, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants