-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few crossrefs + update Zygote's page #2064
Conversation
docs/src/models/losses.md
Outdated
@@ -21,7 +21,7 @@ loss(ŷ, y, agg=x->mean(w .* x)) # weighted mean | |||
loss(ŷ, y, agg=identity) # no aggregation. | |||
``` | |||
|
|||
### Function listing | |||
## Function listing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/src/training/zygote.md
Outdated
Zygote.diaghessian | ||
Zygote.withjacobian | ||
Zygote.withgradient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my vote would be to include withgradient
alongside gradient. Then this section would just be about second derivatives, so it can have a heading more useful than "utilities".
However, these are very limited, Zygote over Zygote never works that well. So perhaps it needs disclaimers here.
And perhaps it wants explanation of how to use hessian with destructure, since oherwise it can't act on a Flux model parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Such a Hessian example is now in destructure
's own page)
docs/src/training/zygote.md
Outdated
Zygote.diaghessian | ||
Zygote.withjacobian | ||
Zygote.withgradient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Such a Hessian example is now in destructure
's own page)
Yes, went through the page and decided to remove this section! |
h2
(##
) does not appear in the sidebarPR Checklist