-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example to the readme? #2067
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b7cf9d
add example to readme
mcabbott b490002
add installation note, tweak
mcabbott a22a904
tweak wording, remove tutorials link
mcabbott 37cdcca
try adding comments
mcabbott 6689513
mv slack to text, add downloads badge
mcabbott 1a42167
change to use logitcrossentropy
mcabbott e1ca78b
mention that loss(x,y) closes over model
mcabbott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this business of defining a
loss
which, unlike whatFlux.Losses
calls a loss, closes over themodel
, was pretty confusing to me when I first tried Flux.train!
needs two different objects with implicit references to the model (andoptim
ends up with them), but does not seem to see the model itself? That's pretty weird.IMO we should define
crossentropy(m, x, y) = crossentropy(m(x), y)
globally, and make Flux 0.14 do this, which is much less confusing:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems the way forward to move
train!
away fromParams
.